Messages in this thread | | | Date | Fri, 28 Jul 2023 19:27:05 +0530 | Subject | Re: [PATCH v5 1/2] dt-bindings: nvmem: sec-qfprom: Add bindings for secure qfprom | From | Komal Bajaj <> |
| |
On 7/27/2023 2:39 PM, Pavan Kondeti wrote: > On Mon, Jul 24, 2023 at 02:08:48PM +0530, Komal Bajaj wrote: >> This patch adds bindings for secure qfprom found in QCOM SOCs. >> Secure QFPROM driver is based on simple nvmem framework. >> >> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com> >> --- >> .../bindings/nvmem/qcom,sec-qfprom.yaml | 58 +++++++++++++++++++ >> 1 file changed, 58 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/nvmem/qcom,sec-qfprom.yaml >> > [...] > >> +$id: http://devicetree.org/schemas/nvmem/qcom,sec-qfprom.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies Inc, Secure QFPROM Efuse >> + >> +maintainers: >> + - Komal Bajaj <quic_kbajaj@quicinc.com> >> + >> +description: | >> + For some of the Qualcomm SoC's, it is possible that >> + the qfprom region is protected from non-secure access. >> + In such situations, linux will have to use secure calls >> + to read the region. >> + >> +allOf: >> + - $ref: nvmem.yaml# >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - qcom,qdu1000-sec-qfprom >> + - const: qcom,sec-qfprom >> + >> + reg: >> + items: >> + - description: The secure qfprom corrected region. >> + >> +required: >> + - compatible >> + - reg >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/qcom,gcc-sc7180.h> >> + > minor nitpick: > > Since this device does not have any clocks, the above header inclusion > can be dropped.
Yes, it is not needed, will drop it.
Thanks Komal
> >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + efuse@221c8000 { >> + compatible = "qcom,qdu1000-sec-qfprom", "qcom,sec-qfprom"; >> + reg = <0 0x221c8000 0 0x1000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + multi_chan_ddr: multi-chan-ddr@12b { >> + reg = <0x12b 0x1>; >> + bits = <0 2>; >> + }; >> + }; >> + }; >> + > Thanks, > Pavan
| |