lkml.org 
[lkml]   [2023]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] Add Silicom Platform Driver
Date
Christophe,

Thanks for the comments. See my comments below.

Updated patch will be sent out later after review comments from other reviewers are addressed.

Henry
-----Original Message-----
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Sent: Tuesday, July 25, 2023 5:03 PM
To: Henry Shi <henryshi2018@gmail.com>; hbshi69@hotmail.com; tglx@linutronix.de; mingo@redhat.com; bp@alien8.de; dave.hansen@linux.intel.com; x86@kernel.org; hpa@zytor.com; hdegoede@redhat.com; markgross@kernel.org; jdelvare@suse.com; linux@roeck-us.net; linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org; linux-hwmon@vger.kernel.org
Cc: hb_shi2003@yahoo.com; Huibin Shi <henrys@silicom-usa.com>; Wen Wang <wenw@silicom-usa.com>
Subject: Re: [PATCH] Add Silicom Platform Driver

Caution: This is an external email. Please take care when clicking links or opening attachments.


Le 18/07/2023 à 18:01, Henry Shi a écrit :
> The Silicom platform (silicom-platform) Linux driver for Swisscom
> Business Box (Swisscom BB) as well as Cordoba family products is a
> software solution designed to facilitate the efficient management and
> control of devices through the integration of various Linux
> frameworks. This platform driver provides seamless support for device
> management via the Linux LED framework, GPIO framework, Hardware
> Monitoring (HWMON), and device attributes. The Silicom platform
> driver's compatibility with these Linux frameworks allows applications
> to access and control Cordoba family devices using existing software
> that is compatible with these frameworks. This compatibility
> simplifies the development process, reduces dependencies on
> proprietary solutions, and promotes interoperability with other
> Linux-based systems and software.
>
> Signed-off-by: Henry Shi <henryshi2018@gmail.com>
> ---

[...]

> +static int __init silicom_mc_leds_register(struct device *dev,
> + const struct led_classdev_mc
> +*mc_leds) {
> + struct led_classdev_mc *led;
> + int i, err;
> +
> + for (i = 0; mc_leds[i].led_cdev.name; i++) {
> + /* allocate and copy data from the init constansts */
> + led = devm_kzalloc(dev, sizeof(struct led_classdev_mc),
> + GFP_KERNEL);

sizeof(*led) is shorter.
Mostly a matter of taste.

Maybe even devm_kmemdup()?

Henry: thanks. Devm_kmemdup() API requires additional argument that is not necessary of this driver. I prefer devm_kzalloc for now.

> + if (IS_ERR_OR_NULL(led)) {

if (!led)
is enough.

Henry: OK, changed

> + dev_err(dev, "Failed to alloc
> + led_classdev_mc[%d]: %ld\n", i, PTR_ERR(led));

This kind of message is useless and should be removed (checkpatch should warn about it)

Henry: OK, removed.

> + return -ENOMEM;
> + }
> + memcpy(led, &mc_leds[i], sizeof(*led));
> +
> + led->subled_info = devm_kzalloc(dev, led->num_colors * sizeof(struct mc_subled),
> + GFP_KERNEL);

Maybe even devm_kmemdup()?

> + if (IS_ERR_OR_NULL(led->subled_info)) {

if (!led->subled_info)
is enough.

Henry: OK, changed.

> + dev_err(dev, "Failed to alloc subled_info[%d]: %ld\n",
> + i, PTR_ERR(led->subled_info));

This kind of message is useless and should be removed (checkpatch should warn about it)

Henry: OK, removed.

> + return -ENOMEM;
> + }
> + memcpy(led->subled_info, mc_leds[i].subled_info,
> + led->num_colors * sizeof(struct mc_subled));
> +
> + err = devm_led_classdev_multicolor_register(dev, led);
> + if (err) {
> + dev_err(dev, "Failed to register[%d]: %d\n", i, err);
> + return err;
> + }
> + }
> +
> + return 0;
> +}

[...]

\
 
 \ /
  Last update: 2023-07-28 15:00    [W:0.212 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site