lkml.org 
[lkml]   [2023]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next 5/9] page_pool: don't use driver-set flags field directly
From
Date
On 2023/7/27 22:43, Alexander Lobakin wrote:

>
> struct page_pool {
> struct page_pool_params p;
> - long pad;
> +
> + bool dma_map:1; /* Perform DMA mapping */
> + enum {
> + PP_DMA_SYNC_ACT_DISABLED = 0, /* Driver didn't ask to sync */
> + PP_DMA_SYNC_ACT_DO, /* Perform DMA sync ops */
> + } dma_sync_act:1;
> + bool page_frag:1; /* Allow page fragments */
>

Isn't it more common or better to just remove the flags field in
'struct page_pool_params' and pass the flags by parameter like
below, so that patch 4 is not needed?

struct page_pool *page_pool_create(const struct page_pool_params *params,
unsigned int flags);

\
 
 \ /
  Last update: 2023-07-28 14:37    [W:0.180 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site