Messages in this thread | | | Subject | Re: [PATCH net-next 5/9] page_pool: don't use driver-set flags field directly | From | Yunsheng Lin <> | Date | Fri, 28 Jul 2023 20:36:50 +0800 |
| |
On 2023/7/27 22:43, Alexander Lobakin wrote:
> > struct page_pool { > struct page_pool_params p; > - long pad; > + > + bool dma_map:1; /* Perform DMA mapping */ > + enum { > + PP_DMA_SYNC_ACT_DISABLED = 0, /* Driver didn't ask to sync */ > + PP_DMA_SYNC_ACT_DO, /* Perform DMA sync ops */ > + } dma_sync_act:1; > + bool page_frag:1; /* Allow page fragments */ >
Isn't it more common or better to just remove the flags field in 'struct page_pool_params' and pass the flags by parameter like below, so that patch 4 is not needed?
struct page_pool *page_pool_create(const struct page_pool_params *params, unsigned int flags);
| |