Messages in this thread Patch in this message | | | From | Will Deacon <> | Subject | [PATCH v3 4/4] scripts/faddr2line: Don't filter out non-function symbols from readelf | Date | Fri, 28 Jul 2023 12:34:15 +0100 |
| |
As Josh points out in 20230724234734.zy67gm674vl3p3wv@treble:
> Problem is, I think the kernel's symbol printing code prints the > nearest kallsyms symbol, and there are some valid non-FUNC code > symbols. For example, syscall_return_via_sysret.
so we shouldn't be considering only 'FUNC'-type symbols in the output from readelf.
Drop the function symbol type filtering from the faddr2line outer loop.
Cc: Josh Poimboeuf <jpoimboe@kernel.org> Cc: John Stultz <jstultz@google.com> Link: https://lore.kernel.org/r/20230724234734.zy67gm674vl3p3wv@treble Signed-off-by: Will Deacon <will@kernel.org> --- scripts/faddr2line | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/faddr2line b/scripts/faddr2line index da734af90036..47a010615903 100755 --- a/scripts/faddr2line +++ b/scripts/faddr2line @@ -267,7 +267,7 @@ __faddr2line() { DONE=1 - done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK} -v fn=$sym_name '$4 == "FUNC" && $8 == fn') + done < <(${READELF} --symbols --wide $objfile | sed 's/\[.*\]//' | ${AWK} -v fn=$sym_name '$8 == fn') } [[ $# -lt 2 ]] && usage -- 2.41.0.487.g6d72f3e995-goog
| |