Messages in this thread | | | Date | Fri, 28 Jul 2023 17:02:23 +0530 | Subject | Re: [PATCH v3] cdx: add MSI support for CDX bus | From | "Gupta, Nipun" <> |
| |
Hi Thomas,
Do you have any further comments on this patch. Can you please help in review of this version of the patch?
Thanks, Nipun
On 7/10/2023 4:58 PM, Nipun Gupta wrote: > Add CDX-MSI domain per CDX controller with gic-its domain as > a parent, to support MSI for CDX devices. CDX devices allocate > MSIs from the CDX domain. Also, introduce APIs to alloc and free > IRQs for CDX domain. > > In CDX subsystem firmware is a controller for all devices and > their configuration. CDX bus controller sends all the write_msi_msg > commands to firmware running on RPU and the firmware interfaces with > actual devices to pass this information to devices > > Since, CDX controller is the only way to communicate with the Firmware > for MSI write info, CDX domain per controller required in contrast to > having a CDX domain per device. > > Co-developed-by: Nikhil Agarwal <nikhil.agarwal@amd.com> > Signed-off-by: Nikhil Agarwal <nikhil.agarwal@amd.com> > Co-developed-by: Abhijit Gangurde <abhijit.gangurde@amd.com> > Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com> > Signed-off-by: Nipun Gupta <nipun.gupta@amd.com> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com> > Tested-by: Nikhil Agarwal <nikhil.agarwal@amd.com> > --- > > Changes v2->v3: > - Rebased on Linux 6.5rc1 > - Used FW provided 'msi_dev_id' as device ID for GIC instead of 'req_id'.
| |