lkml.org 
[lkml]   [2023]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] drm/atomic-helper: Update reference to drm_crtc_force_disable_all()
Date
Geert Uytterhoeven <geert@linux-m68k.org> writes:

> Hi Javier,
>
> On Fri, Jul 28, 2023 at 11:53 AM Javier Martinez Canillas
> <javierm@redhat.com> wrote:
>> Geert Uytterhoeven <geert+renesas@glider.be> writes:
>> > drm_crtc_force_disable_all() was renamed to
>> > drm_helper_force_disable_all(), but one reference was not updated.
>> >
>> > Fixes: c2d88e06bcb98540 ("drm: Move the legacy kms disable_all helper to crtc helpers")
>>
>> The dim tool complains that:
>>
>> -:10: WARNING:BAD_FIXES_TAG: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")'
>>
>> So I've fixed it locally to only use the first 12 chars of the sha1.
>
> Good luck restoring them in the future (you do care about Y2038,
> do you? ;-)
>

Fair. I fixed it not only because checkpatch complained but also to make
it consistent with the rest of the Fixes: tag in the tree, in case that
people have automation in place having the assumption of the 12 chars...

--
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

\
 
 \ /
  Last update: 2023-07-28 12:01    [W:0.031 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site