Messages in this thread | | | From | John Ogness <> | Subject | Re: [PATCH printk v2 2/8] printk: Provide debug_store() for nbcon debugging | Date | Fri, 28 Jul 2023 23:07:08 +0206 |
| |
On 2023-07-28, Petr Mladek <pmladek@suse.com> wrote: >> + r = vprintk_store(2, 7, NULL, fmt, args); > > We should probably use one of the LOG_LOCALX numbers, e.g. > > #define LOG_LOCAL0 (16<<3) > > Also, please use LOGLEVEL_DEBUG instead of the hard coded "7".
OK.
I am also open to dropping the function and its use. When developing the ringbuffer I also had a similar function but never attempted to publish it. It is useful for developing/testing/debugging, but once everything works as it should it has no real purpose. I have no problems keeping the debug stuff hidden in my own private toolbox.
John
| |