Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [PATCH v10 2/6] iommufd: Allow passing in iopt_access_list_id to iopt_remove_access() | Date | Fri, 28 Jul 2023 04:18:29 +0000 |
| |
> From: Nicolin Chen <nicolinc@nvidia.com> > Sent: Friday, July 28, 2023 4:25 AM > > This is a preparatory change for ioas replacement support for access. > The replacement routine does an iopt_add_access() at a new IOAS first > and then iopt_remove_access() at the old IOAS upon the success of the > first call. However, the first call overrides the iopt_access_list_id > in the access struct, resulting in that id un-erased in the xarray. > > Add an iopt_access_list_id in iopt_remove_access, so the replacement > routine can save the id before it gets overwritten, and pass the id > in iopt_remove_access() for a proper cleanup. > > The existing callers should just pass in access->iopt_access_list_id. > > Suggested-by: Jason Gunthorpe <jgg@nvidia.com> > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
| |