lkml.org 
[lkml]   [2023]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: netsec: Ignore 'phy-mode' on SynQuacer in DT mode
On Fri, Jul 28, 2023 at 07:07:36PM +0200, Andrew Lunn wrote:
> On Fri, Jul 28, 2023 at 09:35:00PM +0900, Masahisa Kojima wrote:

> > "rgmii-id" is correct, configured by board level.
> > The latest EDK2 firmware was already modified to use the correct value
> > for DT(Thank you, Ard).
> > http://snapshots.linaro.org/components/kernel/leg-96boards-developerbox-edk2/100/

Thanks, that does seem to be working.

> If the firmware has been fixed, i would actually do something like:

> err = of_get_phy_mode(pdev->dev.of_node, &priv->phy_interface);
> if (err)
> return err;

> if (of_machine_is_compatible("socionext,developer-box") &&
> priv->phy_interface != PHY_INTERFACE_MODE_RGMII_ID) {
> pr_warn(FW_WARN, "Working around broken firmware. Please upgrade your firmware");
> priv->phy_interface = PHY_INTERFACE_MODE_RGMII_ID;
> }

It is not clear to me that the release channels for this firmware are
sufficiently clear to users for this to be constructive.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-07-28 19:13    [W:0.089 / U:0.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site