Messages in this thread | | | Date | Fri, 28 Jul 2023 18:09:45 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH] dt-bindings: clock: xlnx,versal-clk: drop select:false |
| |
On Fri, Jul 28, 2023 at 06:59:23PM +0200, Krzysztof Kozlowski wrote: > select:false makes the schema basically ignored and not effective, which > is clearly not what we want for a device binding. > > Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver") > Cc: <stable@vger.kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks for spotting it! Validation of the other patch seems to function as intended with this applied.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks, Conor.
> > --- > > Cc: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com> > --- > Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml > index e9cf747bf89b..04ea327d5313 100644 > --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml > +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml > @@ -14,8 +14,6 @@ description: | > reads required input clock frequencies from the devicetree and acts as clock > provider for all clock consumers of PS clocks. > > -select: false > - > properties: > compatible: > oneOf: > -- > 2.34.1 > [unhandled content-type:application/pgp-signature] | |