Messages in this thread | | | Date | Fri, 28 Jul 2023 09:51:11 -0700 | Subject | Re: [PATCH v2] x86/APM: drop the duplicate APM_MINOR_DEV macro | From | Sohil Mehta <> |
| |
Just a nit, the tip tree handbook says:
> "The condensed patch description in the subject line should start with > a uppercase letter and ..."
https://docs.kernel.org/process/maintainer-tip.html?highlight=tip+maintainer#patch-subject
On 7/27/2023 6:11 PM, Randy Dunlap wrote: > This source file already includes <linux/miscdevice.h>, which contains > the same macro. It doesn't need to be defined here again. > > Fixes: 874bcd00f520 ("apm-emulation: move APM_MINOR_DEV to include/linux/miscdevice.h") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
| |