Messages in this thread | | | Date | Thu, 27 Jul 2023 17:36:01 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] serial: core: Replace strncmp()+strlen() with plain strcmp() |
| |
On Thu, Jul 27, 2023 at 02:59:37PM +0300, Andy Shevchenko wrote: > On Thu, Jul 27, 2023 at 12:05:07PM +0300, Andy Shevchenko wrote: > > There is no sense to call strlen() ahead of strncmp(). > > The same effect can be achieved by calling strcmp() directly. > > Replace strncmp()+strlen() with plain strcmp(). > > It seems I will have more against serial core, perhaps it makes sense to unite > them in a single series.
Actually this change is simply wrong. Sorry for the noise.
-- With Best Regards, Andy Shevchenko
| |