Messages in this thread | | | From | Michael Shavit <> | Date | Thu, 27 Jul 2023 22:04:04 +0800 | Subject | Re: [PATCH v4 02/13] iommu/arm-smmu-v3: Add smmu_s1_cfg to smmu_master |
| |
Awesome that helps a lot. These are the patches I have in mind:
1. Move ctx_desc out of s1_cfg 2. Replace domain->s1_cfg with `struct arm_smmu_ctx_desc_cfg cd_table` 3. Move stall_enabled from domain to arm_smmu_ctx_desc_cfg 4. Accept an arm_smmu_master instead of an arm_smmu_domain as the parameter for arm_smmu_write_ctx_desc --- arm_smmu_write_ctx_desc can simply get the cd_table it writes to from master->domain->cd_table; this get's replaced by master->cd_table in subsequent commits. --- SVA is weird if we cut changes here: it iterates over all masters a domain is attached to in order to call arm_smmu_write_ctx_desc(), which ends up writing to the shared cd_table since in master->domain. This becomes more sensible once masters stop sharing the cd _table in subsequent commits. --- arm_smmu_write_ctx_desc is used to sync the cd for all masters the domain was attached to. Now that SVA is calling it in a loop, and to break the dependency on arm_smmu_domain, we should only sync for the master passed in as the parameter 5. Introduce a skip_cd_sync parameter to arm_smmu_write_ctx_desc so that arm_smmu_domain_finalise_s1 can skip the sync_cd before the cd_table is attached to the master. Before the previous commit, arm_smmu_domain_finalise_s1 was calling arm_smmu_write_ctx_desc() before adding the master to the domain->devices list, which was used by arm_sync_smmu() to issue sync commands to masters. This optimization was broken by the previous commit since we stopped depending on domain->devices. 6. Move cd_table from domain to arm_smmu_master->cd_table.
| |