Messages in this thread Patch in this message | | | From | Mark O'Donovan <> | Subject | [PATCH 2/2] nvme-auth: set explanation code for failure2 msgs | Date | Thu, 27 Jul 2023 13:47:48 +0000 |
| |
These error cases were not setting an auth-failure-reason-code-explanation. This means an AUTH_Failure2 message will be sent with an explanation value of 0 which is a reserved value.
Signed-off-by: Mark O'Donovan <shiftee@posteo.net> --- drivers/nvme/host/auth.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c index e1a98647c3a2..094f37e11921 100644 --- a/drivers/nvme/host/auth.c +++ b/drivers/nvme/host/auth.c @@ -760,6 +760,7 @@ static void nvme_queue_auth_work(struct work_struct *work) ret = nvme_auth_dhchap_setup_host_response(ctrl, chap); mutex_unlock(&ctrl->dhchap_auth_mutex); if (ret) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; chap->error = ret; goto fail2; } @@ -776,6 +777,7 @@ static void nvme_queue_auth_work(struct work_struct *work) tl = ret; ret = nvme_auth_submit(ctrl, chap->qid, chap->buf, tl, true); if (ret) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; chap->error = ret; goto fail2; } @@ -811,6 +813,7 @@ static void nvme_queue_auth_work(struct work_struct *work) ret = nvme_auth_dhchap_setup_ctrl_response(ctrl, chap); if (ret) { mutex_unlock(&ctrl->dhchap_auth_mutex); + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; chap->error = ret; goto fail2; } @@ -830,8 +833,10 @@ static void nvme_queue_auth_work(struct work_struct *work) __func__, chap->qid); tl = nvme_auth_set_dhchap_success2_data(ctrl, chap); ret = nvme_auth_submit(ctrl, chap->qid, chap->buf, tl, true); - if (ret) + if (ret) { + chap->status = NVME_AUTH_DHCHAP_FAILURE_FAILED; chap->error = ret; + } } if (!ret) { chap->error = 0; -- 2.39.2
| |