Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 27 Jul 2023 15:32:42 +0200 | Subject | Re: [PATCH] [v2] rtc: bq4802: add sparc dependency |
| |
On Wed, Jul 19, 2023 at 9:28 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The added HAS_IOPORT dependency might not actually be necessary as Geert > points out, but the driver is also only used on one architecture. Sparc > is also a special case here since it converts port numbers into virtual > addresses rather than having them mapped into a particular part of the > __iomem address space, so the difference is actually not important here. > > Add a dependency on sparc, but allow compile-testing otherwise, to > make this clearer without anyone having to spend much time modernizing > the driver beyond that. > > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: David S. Miller <davem@davemloft.net> > Link: https://lore.kernel.org/all/CAMuHMdWEx0F=fNei4Bz_JPkuvoaN-+zk08h0i8KnSi_VjO615g@mail.gmail.com/ > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > v2: split dependency into two lines, as suggested by Geert
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |