lkml.org 
[lkml]   [2023]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 08/30] usb: gadget/atmel_usba_udc: Use devm_platform_get_and_ioremap_resource()
From


On 26.07.2023 14:37, Yangtao Li wrote:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>

> ---
> drivers/usb/gadget/udc/atmel_usba_udc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 6c0ed3fa5eb1..02b1bef5e22e 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -2285,15 +2285,13 @@ static int usba_udc_probe(struct platform_device *pdev)
> udc->gadget = usba_gadget_template;
> INIT_LIST_HEAD(&udc->gadget.ep_list);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, CTRL_IOMEM_ID);
> - udc->regs = devm_ioremap_resource(&pdev->dev, res);
> + udc->regs = devm_platform_get_and_ioremap_resource(pdev, CTRL_IOMEM_ID, &res);
> if (IS_ERR(udc->regs))
> return PTR_ERR(udc->regs);
> dev_info(&pdev->dev, "MMIO registers at %pR mapped at %p\n",
> res, udc->regs);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, FIFO_IOMEM_ID);
> - udc->fifo = devm_ioremap_resource(&pdev->dev, res);
> + udc->fifo = devm_platform_get_and_ioremap_resource(pdev, FIFO_IOMEM_ID, &res);
> if (IS_ERR(udc->fifo))
> return PTR_ERR(udc->fifo);
> dev_info(&pdev->dev, "FIFO at %pR mapped at %p\n", res, udc->fifo);

\
 
 \ /
  Last update: 2023-07-27 07:36    [W:0.135 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site