Messages in this thread | | | Date | Thu, 27 Jul 2023 13:21:17 +0200 | Subject | Re: [PATCH v1 2/2] clk: rockchip: rk3588: Adjust the GATE_LINK parameter | From | Krzysztof Kozlowski <> |
| |
On 27/07/2023 12:11, Elaine Zhang wrote: > Using Id instead of name, if use name needs to use __clk_lookup(). > But __clk_lookup() is not exported and is not friendly for GKI. > > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > ---
> static void __init rk3588_clk_init(struct device_node *np) > diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h > index b5616bca7b44..864a321ab362 100644 > --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h > +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h > @@ -733,8 +733,9 @@ > #define ACLK_AV1_PRE 718 > #define PCLK_AV1_PRE 719 > #define HCLK_SDIO_PRE 720 > +#define PCLK_VO1GRF 721
Bindings are separate patches.
Please run scripts/checkpatch.pl and fix reported warnings. Some warnings can be ignored, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear.
Best regards, Krzysztof
| |