Messages in this thread | | | Date | Thu, 27 Jul 2023 13:19:51 +0300 | Subject | Re: [PATCH v2 05/22] i2c: designware: Remove #ifdef guards for PM related functions | From | Jarkko Nikula <> |
| |
On 7/22/23 14:50, Paul Cercueil wrote: > Use the new PM macros for the suspend and resume functions to be > automatically dropped by the compiler when CONFIG_PM or > CONFIG_PM_SLEEP are disabled, without having to use #ifdef guards. > > This has the advantage of always compiling these functions in, > independently of any Kconfig option. Thanks to that, bugs and other > regressions are subsequently easier to catch. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > Cc: Jan Dabros <jsd@semihalf.com> > --- > drivers/i2c/busses/i2c-designware-platdrv.c | 22 ++++++--------------- > 1 file changed, 6 insertions(+), 16 deletions(-) > Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
| |