Messages in this thread | | | Date | Thu, 27 Jul 2023 10:48:05 +0100 | Subject | Re: [PATCH] ACPI: scan: Create platform device for CS35L56 | From | Richard Fitzgerald <> |
| |
On 26/7/23 15:13, Hans de Goede wrote: > Hi Richard, > > On 7/26/23 13:27, Richard Fitzgerald wrote: >> From: Simon Trimmer <simont@opensource.cirrus.com> >> >> The ACPI device CSC3556 is a Cirrus Logic CS35L56 mono amplifier which >> is used in multiples, and can be connected either to I2C or SPI. >> >> There will be multiple instances under the same Device() node. Add it >> to ignore_serial_bus_ids and handle it in the serial-multi-instantiate >> driver. >> >> Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com> >> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> > > Thanks, patch looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > I have 1 other serial-multi-instantiate.c patches in my fixes branch (see below) and since this just adds new hw-ids I think this can go upstream through my fixes branch too. > > Rafael, do you agree with me taking this upstream as a 6.5 fix? And if yes may I have your ack for that ? > > About that 1 patch, that adds a new IRQ type: IRQ_RESOURCE_AUTO and I wonder if this patch should not use that same new type right from the start: > > https://git.kernel.org/pub/scm/linux/kernel/agit/pdx86/platform-drivers-x86.git/commit/?h=fixes&id=676b7c5ecab36274442887ceadd6dee8248a244f >
Link doesn't work, but I think you mean: https://lore.kernel.org/platform-driver-x86/b9f81a5b-0511-9950-5a20-9e6cbd92d085@redhat.com/T/#t
I'll send a V2 of this CS35L56 patch to use the new IRQ_RESOURCE_AUTO.
| |