Messages in this thread | | | Date | Thu, 27 Jul 2023 07:14:27 +0200 | Subject | Re: [PATCH] x86/paravirt: Fix tlb_remove_table function callback prototype warning | From | Juergen Gross <> |
| |
On 27.07.23 01:11, Kees Cook wrote: > Under W=1, this warning is visible in Clang 16 and newer: > > arch/x86/kernel/paravirt.c:337:4: warning: cast from 'void (*)(struct mmu_gather *, struct page *)' to 'void (*)(struct mmu_gather *, void *)' converts to incompatible function type [-Wcast-function-type-strict] > (void (*)(struct mmu_gather *, void *))tlb_remove_page, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Add a direct wrapper instead, which will make this warning (and > potential KCFI failures) go away. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202307260332.pJntWR6o-lkp@intel.com/ > Cc: Juergen Gross <jgross@suse.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Sami Tolvanen <samitolvanen@google.com> > Cc: Nathan Chancellor <nathan@kernel.org> > Cc: Ajay Kaher <akaher@vmware.com> > Cc: Alexey Makhalov <amakhalov@vmware.com> > Cc: VMware PV-Drivers Reviewers <pv-drivers@vmware.com> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: Dave Hansen <dave.hansen@linux.intel.com> > Cc: virtualization@lists.linux-foundation.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
[unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |