lkml.org 
[lkml]   [2023]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] media: jpeg-core: Remove redundant dev_err()
From
Thanks!

W dniu 27.07.2023 o 12:06, Ruan Jinjie pisze:
> There is no need to call the dev_err() function directly to print a custom
> message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>

Acked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>

> ---
> drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samThsung/s5p-jpeg/jpeg-core.c
> index 5e819b8b38a4..d2c4a0178b3c 100644
> --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> @@ -2870,10 +2870,8 @@ static int s5p_jpeg_probe(struct platform_device *pdev)
>
> /* interrupt service routine registration */
> jpeg->irq = ret = platform_get_irq(pdev, 0);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "cannot find IRQ\n");
> + if (ret < 0)
> return ret;
> - }
>
> ret = devm_request_irq(&pdev->dev, jpeg->irq, jpeg->variant->jpeg_irq,
> 0, dev_name(&pdev->dev), jpeg);

\
 
 \ /
  Last update: 2023-07-27 11:07    [W:0.031 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site