lkml.org 
[lkml]   [2023]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: vme_user: fix check alignment should match open parenthesis
On Sat, Jul 08, 2023 at 12:55:11AM -0300, Alexon Oliveira wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Alignment should match open parenthesis
>
> #132: FILE: drivers/staging/vme_user/vme_bridge.h:132
> #135: FILE: drivers/staging/vme_user/vme_bridge.h:135
> #139: FILE: drivers/staging/vme_user/vme_bridge.h:139
> #142: FILE: drivers/staging/vme_user/vme_bridge.h:142
> #144: FILE: drivers/staging/vme_user/vme_bridge.h:144
> #146: FILE: drivers/staging/vme_user/vme_bridge.h:146
> #148: FILE: drivers/staging/vme_user/vme_bridge.h:148
> #152: FILE: drivers/staging/vme_user/vme_bridge.h:152
> #163: FILE: drivers/staging/vme_user/vme_bridge.h:163
> #173: FILE: drivers/staging/vme_user/vme_bridge.h:173
> #175: FILE: drivers/staging/vme_user/vme_bridge.h:175

We don't need all of these lines.

> Signed-off-by: Alexon Oliveira <alexondunkan@gmail.com>

Please don't indent your signed-off-by line, that should be to the left.

>
> diff --git a/drivers/staging/vme_user/vme_bridge.h b/drivers/staging/vme_user/vme_bridge.h
> index 11df0a5e7f7b..a0d7a8db239d 100644
> --- a/drivers/staging/vme_user/vme_bridge.h
> +++ b/drivers/staging/vme_user/vme_bridge.h
> @@ -128,28 +128,21 @@ struct vme_bridge {
> struct mutex irq_mtx;
>
> /* Slave Functions */
> - int (*slave_get)(struct vme_slave_resource *, int *,
> - unsigned long long *, unsigned long long *, dma_addr_t *,
> - u32 *, u32 *);
> - int (*slave_set)(struct vme_slave_resource *, int, unsigned long long,
> - unsigned long long, dma_addr_t, u32, u32);
> + int (*slave_get)(struct vme_slave_resource *, int *, unsigned long long *,
> + unsigned long long *, dma_addr_t *, u32 *, u32 *);
> + int (*slave_set)(struct vme_slave_resource *, int, unsigned long long, unsigned long long, dma_addr_t, u32, u32);

Did you run your patch through checkpatch.pl after making this change?
I think you just added more warnings...

thanks,

greg k-h

\
 
 \ /
  Last update: 2023-07-27 10:09    [W:0.038 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site