Messages in this thread | | | Date | Thu, 27 Jul 2023 13:31:19 +0530 | From | Varadarajan Narayanan <> | Subject | Re: [PATCH v6 1/5] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy |
| |
On Thu, Jul 27, 2023 at 08:47:07AM +0200, Krzysztof Kozlowski wrote: > On 27/07/2023 08:33, Varadarajan Narayanan wrote: > > Document the M31 USB2 phy present in IPQ5332. > > > > Co-developed-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > > > +properties: > > + "#phy-cells": > > + const: 0 > > + > > + compatible: > > + items: > > + - const: qcom,ipq5332-usb-hsphy > > Please keep compatible as first property. > > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: cfg_ahb > > + > > + resets: > > + maxItems: 1 > > + > > + vdd-supply: > > + description: > > + Phandle to 5V regulator supply to PHY digital circuit. > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/qcom,ipq5332-gcc.h> > > + usb2-phy@7b000 { > > This was actually better before as usb-phy, I don't know why did you > changed. Especially that you already changed once to usb-phy and this > got review tag. It's fine. If there is going to be resubmit then fix > these two issues.
Based on Bjorn's and Rob's comments (https://lore.kernel.org/linux-arm-msm/20230724160136.GA3619408-robh@kernel.org/) I assumed they preferred usb2-phy and hence changed. Will revert back to usb-phy if I post another version.
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thanks Varada
| |