Messages in this thread | | | Date | Thu, 27 Jul 2023 15:54:02 +0800 | Subject | Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support | From | Fenglin Wu <> |
| |
On 7/27/2023 3:10 PM, Krzysztof Kozlowski wrote: > On 18/07/2023 10:02, Krzysztof Kozlowski wrote: >> On 18/07/2023 09:59, Fenglin Wu wrote: >> >>>>> Just FYI,the change log was updated in the cover letter here: >>>>> https://lore.kernel.org/linux-arm-msm/20230718062639.2339589-1-quic_fenglinw@quicinc.com/T/#m3819b50503ef19e0933a10bf797351a4af35537f >>>>> >>>>> Also the commit text and the driver change were also updated accordingly >>>>> to address your review comment by removing 'pm7550ba-vib' compatible string. >>>> >>>> Removing compatible was never my feedback. Did you read: >>>> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 >>>> ? >>>> >>> Okay, so do you want me to add 'pm7550ba-vib' as a fallback compatible >>> like this? >>> >>> properties: >>> compatible: >>> - enum: >>> - - qcom,pm8058-vib >>> - - qcom,pm8916-vib >>> - - qcom,pm8921-vib >>> - - qcom,pmi632-vib >>> - - qcom,pm7250b-vib >>> - - qcom,pm7325b-vib >>> + oneOf: >>> + - enum: >>> + - qcom,pm8058-vib >>> + - qcom,pm8916-vib >>> + - qcom,pm8921-vib >>> + - qcom,pmi632-vib >>> + - qcom,pm7250b-vib >>> + - qcom,pm7325b-vib >>> + - items: >>> + - enum: >>> + - qcom,pm7550ba-vib >>> + - const: qcom,pm7325b-vib >>> >> >> Yes > > I wonder why this approved change turned out to something incorrect in > your v3 patch... > Since I got review comments in the driver change and I was told to refactor the driver before adding new HW support. I added the HW type logic in the driver and I was thinking it might be good to add some generic compatible strings to match with the HW type introduced in the driver change.
Anyway, I will update it to what you suggested in next patch.
> Best regards, > Krzysztof >
| |