Messages in this thread | | | Subject | Re: [PATCH v2] bpf: Add length check for SK_DIAG_BPF_STORAGE_REQ_MAP_FD parsing | From | Paolo Abeni <> | Date | Thu, 27 Jul 2023 09:34:41 +0200 |
| |
On Tue, 2023-07-25 at 10:33 +0800, Lin Ma wrote: > The nla_for_each_nested parsing in function bpf_sk_storage_diag_alloc > does not check the length of the nested attribute. This can lead to an > out-of-attribute read and allow a malformed nlattr (e.g., length 0) to > be viewed as a 4 byte integer. > > This patch adds an additional check when the nlattr is getting counted. > This makes sure the latter nla_get_u32 can access the attributes with > the correct length. > > Fixes: 1ed4d92458a9 ("bpf: INET_DIAG support in bpf_sk_storage") > Suggested-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Lin Ma <linma@zju.edu.cn>
I guess this should go via the ebpf tree, right? Setting the delegate accordingly.
Please correct me if I'm wrong.
Thanks!
/P
| |