Messages in this thread | | | Date | Thu, 27 Jul 2023 08:42:52 +0200 | Subject | Re: [PATCH v2] net: stmmac: correct MAC propagation delay | From | Johannes Zink <> |
| |
Hi Richard,
On 7/26/23 20:00, Richard Cochran wrote: > On Mon, Jul 24, 2023 at 12:01:31PM +0200, Johannes Zink wrote: > >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h >> index bf619295d079..d1fe4b46f162 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.h >> @@ -26,6 +26,12 @@ >> #define PTP_ACR 0x40 /* Auxiliary Control Reg */ >> #define PTP_ATNR 0x48 /* Auxiliary Timestamp - Nanoseconds Reg */ >> #define PTP_ATSR 0x4c /* Auxiliary Timestamp - Seconds Reg */ >> +#define PTP_TS_INGR_CORR_NS 0x58 /* Ingress timestamp correction nanoseconds */ >> +#define PTP_TS_EGR_CORR_NS 0x5C /* Egress timestamp correction nanoseconds*/ >> +#define PTP_TS_INGR_CORR_SNS 0x60 /* Ingress timestamp correction subnanoseconds */ >> +#define PTP_TS_EGR_CORR_SNS 0x64 /* Egress timestamp correction subnanoseconds */ > > These two... > >> +#define PTP_TS_INGR_LAT 0x68 /* MAC internal Ingress Latency */ >> +#define PTP_TS_EGR_LAT 0x6c /* MAC internal Egress Latency */ > > do not exist on earlier versions of the IP core. > > I wonder what values are there? >
good catch, I think adding the register definition won't hurt, but if you feel more comfortable about it I can add them only for IP core version 5.
Johannes
> Thanks, > Richard >
-- Pengutronix e.K. | Johannes Zink | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |
| |