Messages in this thread | | | Date | Thu, 27 Jul 2023 22:43:40 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH v2] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue |
| |
Hi Chengfeng,
On Fri, Jul 07, 2023 at 08:49:41AM +0000, Chengfeng Ye wrote: > iproc_i2c_rd_reg() and iproc_i2c_wr_reg() are called from both > interrupt context (e.g. bcm_iproc_i2c_isr) and process context > (e.g. bcm_iproc_i2c_suspend). Therefore, interrupts should be > disabled to avoid potential deadlock. To prevent this scenario, > use spin_lock_irqsave(). > > Fixes: 9a1038728037 ("i2c: iproc: add NIC I2C support") > Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks, Andi
| |