Messages in this thread | | | Subject | Re: [PATCH 0/2] fix vma->anon_vma check for per-VMA locking; fix anon_vma memory ordering | From | Nadav Amit <> | Date | Thu, 27 Jul 2023 13:11:43 -0700 |
| |
> On Jul 27, 2023, at 12:39 PM, Linus Torvalds <torvalds@linuxfoundation.org> wrote: > > On Thu, 27 Jul 2023 at 12:10, Nadav Amit <nadav.amit@gmail.com> wrote: >> >> Interesting. I wonder if you considered adding to READ_ONCE() something >> like: >> >> asm volatile("" : "+g" (x) ); >> >> So later loads (such as baz = *ptr) would reload the updated value. > > Not necessarily a bad idea. Although I suspect you'd want to add > *two* of them - on either side - to make sure any previous loads > wouldn't be moved around it either.
You are right, two are needed.
I’ll give it a shot and see if I see changes to the binary.
| |