Messages in this thread | | | Date | Thu, 27 Jul 2023 13:06:56 -0700 | Subject | Re: [PATCH] x86/APM: drop the duplicate APM_MINOR_DEV macro | From | Sohil Mehta <> |
| |
s/drop/Drop
On 7/26/2023 4:49 PM, Randy Dunlap wrote: > This source file already includes <linux/miscdevice.h>, which contains > the same macro. It doesn't need to be defined here again. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Jiri Kosina <jikos@kernel.org> > Cc: x86@kernel.org > ---
I am not sure if a Fixes tag is really needed for a redundant macro definition. If at all, shouldn't it be 874bcd00f520c ("apm-emulation: move APM_MINOR_DEV to include/linux/miscdevice.h") ?
Either way, Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
| |