Messages in this thread | | | Date | Thu, 27 Jul 2023 21:10:56 +0200 | From | Christian Marangi <> | Subject | Re: [net-next PATCH 3/3] net: dsa: qca8k: limit user ports access to the first CPU port on setup |
| |
On Wed, Jul 26, 2023 at 04:18:51PM +0300, Vladimir Oltean wrote: > On Mon, Jul 24, 2023 at 05:30:58AM +0200, Christian Marangi wrote: > > In preparation for multi-CPU support, set CPU port LOOKUP MEMBER outside > > the port loop and setup the LOOKUP MEMBER mask for user ports only to > > the first CPU port. > > > > This is to handle flooding condition where every CPU port is set as > > target and prevent packet duplication for unknown frames from user ports. > > > > Secondary CPU port LOOKUP MEMBER mask will be setup later when > > port_change_master will be implemented. > > > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> > > --- > > This is kinda "net.git" material, in the sense that it fixes the current > driver behavior with device trees from the future, right?
This is not strictly a fix. The secondary CPU (if defined) doesn't have flood enabled so the switch won't forward packet. It's more of a cleanup/preparation from my point of view. What do you think?
-- Ansuel
| |