Messages in this thread Patch in this message | | | From | Sohil Mehta <> | Subject | [PATCH v2 1/3] x86/smpboot: Remove a stray comment about CPU hotplug | Date | Thu, 27 Jul 2023 18:05:31 +0000 |
| |
This old comment is irrelavant to the logic of disabling interrupts and could be misleading. Remove it.
Now, hlt_play_dead() resembles the code that the comment was initially added for, but, it doesn't make sense anymore because an offlined cpu could also be put into other states such as mwait.
Signed-off-by: Sohil Mehta <sohil.mehta@intel.com> --- arch/x86/kernel/smpboot.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index e1aa2cd7734b..6a09a021b534 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1614,9 +1614,7 @@ void play_dead_common(void) idle_task_exit(); cpuhp_ap_report_dead(); - /* - * With physical CPU hotplug, we should halt the cpu - */ + local_irq_disable(); } -- 2.34.1
| |