Messages in this thread | | | Date | Thu, 27 Jul 2023 19:26:28 +0300 | From | Svyatoslav Ryhel <> | Subject | Re: [PATCH v2 2/2] ARM: tegra: transformers: add connector node |
| |
27 липня 2023 р. 18:11:15 GMT+03:00, Thierry Reding <thierry.reding@gmail.com> написав(-ла): >On Sun, Jun 18, 2023 at 11:50:46AM +0300, Svyatoslav Ryhel wrote: >> All ASUS Transformers have micro-HDMI connector directly available. >> After Tegra HDMI got bridge/connector support, we should use connector >> framework for proper HW description. >> >> Tested-by: Andreas Westman Dorcsak <hedmoo@yahoo.com> # ASUS TF T30 >> Tested-by: Robert Eckelmann <longnoserob@gmail.com> # ASUS TF101 T20 >> Tested-by: Svyatoslav Ryhel <clamor95@gmail.com> # ASUS TF201 T30 >> Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> >> --- >> arch/arm/boot/dts/tegra20-asus-tf101.dts | 22 ++++++++++++++++--- >> .../dts/tegra30-asus-transformer-common.dtsi | 21 ++++++++++++++++-- >> 2 files changed, 38 insertions(+), 5 deletions(-) >> >> diff --git a/arch/arm/boot/dts/tegra20-asus-tf101.dts b/arch/arm/boot/dts/tegra20-asus-tf101.dts >> index c2a9c3fb5b33..97350f566539 100644 >> --- a/arch/arm/boot/dts/tegra20-asus-tf101.dts >> +++ b/arch/arm/boot/dts/tegra20-asus-tf101.dts >> @@ -82,9 +82,11 @@ hdmi@54280000 { >> pll-supply = <&hdmi_pll_reg>; >> hdmi-supply = <&vdd_hdmi_en>; >> >> - nvidia,ddc-i2c-bus = <&hdmi_ddc>; >> - nvidia,hpd-gpio = <&gpio TEGRA_GPIO(N, 7) >> - GPIO_ACTIVE_HIGH>; >> + port@0 { >> + hdmi_out: endpoint { >> + remote-endpoint = <&connector_in>; >> + }; >> + }; > >Does this need a bindings change? nvidia,tegra20-hdmi currently doesn't >support OF graphs, so this would probably fail to validate if we merge >it without a corresponding DT bindings update.
drm/tegra patch is backwards compatible and connector node is optional.
>Thierry
| |