lkml.org 
[lkml]   [2023]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 net-next] dissector: Use 64bits for used_keys
Date

Ratheesh Kannoth <rkannoth@marvell.com> writes:

> As 32bit of dissectory->used_keys are exhausted,

But s/dissectory/dissector/.

Also the subject should probably be:

net: flow_dissector: ...

> increase the size to 64bits.
>
> This is base changes for ESP/AH flow dissector patch.
>
> Please find patch and discussions at
> https://lore.kernel.org/netdev/ZMDNjD46BvZ5zp5I@corigine.com/T/#t
>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>

> diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
> index 8664ed4fbbdf..830f06b2f36d 100644
> --- a/include/net/flow_dissector.h
> +++ b/include/net/flow_dissector.h
> @@ -370,7 +370,8 @@ struct flow_dissector_key {
> };
>
> struct flow_dissector {
> - unsigned int used_keys; /* each bit repesents presence of one key id */
> + unsigned long long used_keys;
> + /* each bit represents presence of one key id */

This unnecessarily adds an extra space before the field name.

> unsigned short int offset[FLOW_DISSECTOR_KEY_MAX];
> };
>
> @@ -430,7 +431,7 @@ void skb_flow_get_icmp_tci(const struct sk_buff *skb,
> static inline bool dissector_uses_key(const struct flow_dissector *flow_dissector,
> enum flow_dissector_key_id key_id)
> {
> - return flow_dissector->used_keys & (1 << key_id);
> + return flow_dissector->used_keys & (1ULL << key_id);
> }
>
> static inline void *skb_flow_dissector_target(struct flow_dissector *flow_dissector,

\
 
 \ /
  Last update: 2023-07-27 18:21    [W:0.172 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site