Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v5 2/2] drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback | Date | Wed, 26 Jul 2023 16:39:11 +0200 |
| |
Javier Martinez Canillas <javierm@redhat.com> writes:
> Drivers are not allowed to fail after drm_atomic_helper_swap_state() has > been called and the new atomic state is stored into the current sw state. > > Since the struct ssd130x_device .data_array is allocated in the encoder's > .atomic_enable callback, the operation can fail and this is after the new > state has been stored. So it can break an atomic mode settings assumption. > > Fix this by having custom helpers to allocate, duplicate and destroy the > plane state, that will take care of allocating and freeing these buffers. > > Suggested-by: Maxime Ripard <mripard@kernel.org> > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > Acked-by: Maxime Ripard <mripard@kernel.org> > Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Pushed to drm-misc (drm-misc-next). Thanks!
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |