Messages in this thread | | | From | Hayes Wang <> | Subject | RE: [PATCH net-next v2 1/2] r8152: adjust generic_ocp_write function | Date | Wed, 26 Jul 2023 09:50:01 +0000 |
| |
Andrew Lunn <andrew@lunn.ch> > Sent: Wednesday, July 26, 2023 4:37 PM [...] > How often is byte_en 0xff? Do you have some benchmark numbers to show > it is worth the complexity?
It is usually used for writing firmware. The firmware contains several blocks of continuous registers.
I think it is worth, even this only saves several numbers of control transfer. This patch could replace 3 control transfers with 1 control transfer. If you could do it with one step, why do you use 3 steps? Besides, a control transfer is a complex process. I think this could reduce the loading of both software and hardware.
Best Regards, Hayes
| |