Messages in this thread | | | Date | Wed, 26 Jul 2023 10:13:53 +0200 | Subject | Re: [PATCH v9 2/5] phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY | From | Oliver Neukum <> |
| |
Hi,
On 25.07.23 05:31, Stanley Chang wrote: > +static int get_phy_data_by_efuse(struct rtk_phy *rtk_phy, > + struct phy_parameter *phy_parameter, int index) > +{ > + struct phy_cfg *phy_cfg = rtk_phy->phy_cfg; > + u8 value = 0; > + struct nvmem_cell *cell; > + struct soc_device_attribute rtk_soc_groot[] = { > + { .family = "Realtek Groot",}, > + { /* empty */ } }; > + > + if (!phy_cfg->check_efuse) > + goto out; > + > + /* Read efuse for usb dc cal */ > + cell = nvmem_cell_get(rtk_phy->dev, "usb-dc-cal"); > + if (IS_ERR(cell)) { > + dev_dbg(rtk_phy->dev, "%s no usb-dc-cal: %ld\n", > + __func__, PTR_ERR(cell)); > + } else { > + unsigned char *buf; > + size_t buf_size; > + > + buf = nvmem_cell_read(cell, &buf_size); > + value = buf[0] & phy_cfg->dc_driving_mask; > + > + kfree(buf); > + nvmem_cell_put(cell);
nvmem_cell_read() can take NULL as the second argument. You are throwing away buf_size anyway.
Regards Oliver
| |