lkml.org 
[lkml]   [2023]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ASoC: loongson: mark OF related data as maybe unused
From
Date
On Wed, 2023-07-26 at 15:06 +0800, YingKun Meng wrote:
> The ASoC Sound Card driver can be compile tested with !CONFIG_OF
> making 'loongson_asoc_dt_ids' unused:
>
> sound/soc/loongson/loongson_card.c:200:34: warning: unused variable
> 'loongson_asoc_dt_ids' [-Wunused-const-variable]

Hmm, why not guard the definition with #ifdef CONFIG_OF instead?

Source text is first and foremost for the human reader, not for the
compiler, and an ifdef clearly shows the condition when the definition
is not used.

> Here we solve it in the same way as [1].
>
> [1] https://lore.kernel.org/all/20201125164452.89239-1-krzk@kernel.org/
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307242008.xqdjgk04-lkp@intel.com
> Fixes: d24028606e76 ("ASoC: loongson: Add Loongson ASoC Sound Card Support")
> Signed-off-by: YingKun Meng <mengyingkun@loongson.cn>
> ---
>  sound/soc/loongson/loongson_card.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/loongson/loongson_card.c b/sound/soc/loongson/loongson_card.c
> index 9ded16329747..7dd7adc13484 100644
> --- a/sound/soc/loongson/loongson_card.c
> +++ b/sound/soc/loongson/loongson_card.c
> @@ -197,7 +197,7 @@ static int loongson_asoc_card_probe(struct platform_device *pdev)
>         return ret;
>  }
>  
> -static const struct of_device_id loongson_asoc_dt_ids[] = {
> +static const struct of_device_id loongson_asoc_dt_ids[] __maybe_unused = {
>         { .compatible = "loongson,ls-audio-card" },
>         { /* sentinel */ },
>  };

--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University

\
 
 \ /
  Last update: 2023-07-26 09:26    [W:0.085 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site