lkml.org 
[lkml]   [2023]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 3/6] media: starfive: camss: Add basic driver
From
Hi Bryan,

Thank you for your comments.

On 2023/7/26 18:58, Bryan O'Donoghue wrote:
> On 19/06/2023 12:28, Jack Zhu wrote:
>> Add basic platform driver for StarFive Camera Subsystem.
>
> Another nit here.
>
> "Add basic driver" isn't a great title. Recommend "Add core driver".
>
> Basic implies a thing that will be added to or improved upon but, this code here is your "core" interface where you do your probing and resource parsing/allocation etc.
>
> Use "core" not "basic" to describe this.
>

Ok, I will modify this title.

> ---
> bod
>

--
Regards,

Jack Zhu

\
 
 \ /
  Last update: 2023-07-27 00:19    [W:0.427 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site