Messages in this thread Patch in this message | | | Date | Wed, 26 Jul 2023 14:12:35 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 5/5] Revert "checkpatch: Error out if deprecated RCU API used" |
| |
On Tue, Jul 25, 2023 at 11:29:10PM +0000, Joel Fernandes (Google) wrote: > The check for single-argument kfree_rcu() is no longer needed as all > users have been converted. > > This reverts commit 1eacac3255495be7502d406e2ba5444fb5c3607c. > > Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Good eyes, thank you!
I applied this with an updated commit log as shown below. Please let me know if I messed something up.
Thanx, Paul
------------------------------------------------------------------------
commit 1f5f0053f7662385d9ead46d4c0d2d4fe9aaa73a Author: Joel Fernandes (Google) <joel@joelfernandes.org> Date: Tue Jul 25 23:29:10 2023 +0000
Revert "checkpatch: Error out if deprecated RCU API used" The definition for single-argument kfree_rcu() has been removed, so that any further attempt to use it will result in a build error. Because of this build error, there is no longer any need for a special check in checkpatch.pl. Therefore, revert commit 1eacac3255495be7502d406e2ba5444fb5c3607c. Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index a9841148cde2..528f619520eb 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -6422,15 +6422,6 @@ sub process { } } -# check for soon-to-be-deprecated single-argument k[v]free_rcu() API - if ($line =~ /\bk[v]?free_rcu\s*\([^(]+\)/) { - if ($line =~ /\bk[v]?free_rcu\s*\([^,]+\)/) { - ERROR("DEPRECATED_API", - "Single-argument k[v]free_rcu() API is deprecated, please pass rcu_head object or call k[v]free_rcu_mightsleep()." . $herecurr); - } - } - - # check for unnecessary "Out of Memory" messages if ($line =~ /^\+.*\b$logFunctions\s*\(/ && $prevline =~ /^[ \+]\s*if\s*\(\s*(\!\s*|NULL\s*==\s*)?($Lval)(\s*==\s*NULL\s*)?\s*\)/ &&
| |