Messages in this thread Patch in this message | | | Date | Wed, 26 Jul 2023 20:21:47 +0200 | From | Stephan Gerhold <> | Subject | Re: [PATCH 1/2] clk: qcom: reset: Increase max reset delay |
| |
On Wed, Jul 26, 2023 at 03:26:19PM +0200, Konrad Dybcio wrote: > u8 limits us to 255 microseconds of delay. Promote the delay variable to > u16 to hold bigger values. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
It would be clearer to change this together with an actual user that needs > 255us. AFAICT atm MSM8909 is the only user of this and it has just 15us.
Thanks, Stephan
> --- > drivers/clk/qcom/reset.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/reset.h b/drivers/clk/qcom/reset.h > index 9a47c838d9b1..fe0561bf53d4 100644 > --- a/drivers/clk/qcom/reset.h > +++ b/drivers/clk/qcom/reset.h > @@ -11,7 +11,7 @@ > struct qcom_reset_map { > unsigned int reg; > u8 bit; > - u8 udelay; > + u16 udelay; > u32 bitmask; > }; > > > -- > 2.41.0 >
| |