Messages in this thread | | | Date | Wed, 26 Jul 2023 14:38:56 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v8 1/4] vfio: Do not allow !ops->dma_unmap in vfio_pin/unpin_pages() |
| |
On Wed, Jul 26, 2023 at 11:33:49AM -0600, Alex Williamson wrote: > On Mon, 24 Jul 2023 12:47:04 -0700 > Nicolin Chen <nicolinc@nvidia.com> wrote: > > > A driver that doesn't implement ops->dma_unmap shouldn't be allowed to do > > vfio_pin/unpin_pages(), though it can use vfio_dma_rw() to access an iova > > range. Deny !ops->dma_unmap cases in vfio_pin/unpin_pages(). > > > > Suggested-by: Kevin Tian <kevin.tian@intel.com> > > Reviewed-by: Kevin Tian <kevin.tian@intel.com> > > Reviewed-by: Yi Liu <yi.l.liu@intel.com> > > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> > > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com> > > --- > > drivers/vfio/vfio_main.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > I assume these go through iommufd.
Yep, I think it is next up, thanks
Jason
| |