lkml.org 
[lkml]   [2023]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1 2/2] scsi: ufs: ufs-qcom: check host controller state
On Wed, Jul 26, 2023 at 12:57:10AM +0530, Nitin Rawat wrote:
> Check host controller state before sending hibern8 command.
>

Please read https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> Signed-off-by: Manish Pandey <quic_mapa@quicinc.com>

Please read https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

> Signed-off-by: Nitin Rawat <quic_nitirawa@quicinc.com>
> ---
> drivers/ufs/host/ufs-qcom.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 8d6fd4c3324f..95412e98a598 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1254,6 +1254,10 @@ static int ufs_qcom_clk_scale_notify(struct ufs_hba *hba,
> struct ufs_pa_layer_attr *dev_req_params = &host->dev_req_params;
> int err = 0;
>
> + /* check the host controller state before sending hibern8 cmd */

That is exactly what the two lines does, but the comment does not
provide any insight into why this is done. Keeping a comment here seems
relevant, please make sure that it adds value.

Thanks,
Bjorn

> + if (!ufshcd_is_hba_active(hba))
> + return 0;
> +
> if (status == PRE_CHANGE) {
> err = ufshcd_uic_hibern8_enter(hba);
> if (err)
> --
> 2.17.1
>

\
 
 \ /
  Last update: 2023-07-26 07:32    [W:0.065 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site