Messages in this thread | | | Date | Wed, 26 Jul 2023 17:56:04 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v1 3/5] dt-bindings: net: Add HPE GXP UMAC |
| |
On Wed, Jul 26, 2023 at 02:35:48PM +0000, Hawkins, Nick wrote: > > > > Do both ports get the sane MAC address? > > > > > > No they do not. The first one will get the MAC address, the second > > > will be an external phy we are managing via the MDIO path. > > > Then please put the mac-address property in the correct place, inside > port@0. > > Greetings Andrew, > > I was mistaken, the Mac address belongs with UMAC, > not the phys. The reason ports are listed here is > because having two separate phy-handles > in one node is not allowed. The layout of the > hardware inside the GXP is unconventional.
It is not that unconventional. See
Documentation/devicetree/bindings/net/marvell-orion-net.txt
This is an Ethernet block, with two MACs inside it. Each MAC gets its own subblock containing MAC specific properties like the MAC address, phy-handle, etc.
Andrew
| |