lkml.org 
[lkml]   [2023]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6] wifi: ath5k: remove phydir check from ath5k_debug_init_device()
From
Date
Minjie Du <duminjie@vivo.com> wrote:

> 'phydir' returned from debugfs_create_dir() is checked against NULL.
> As the debugfs API returns an error pointer,
> the returned value can never be NULL.
>
> Therefore, as the documentation suggests that the check is unnecessary
> and other debugfs calls have no operation in error cases,
> it is advisable to completely eliminate the check.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>

Patch applied to ath-next branch of ath.git, thanks.

f7eb8315b22a wifi: ath5k: remove phydir check from ath5k_debug_init_device()

--
https://patchwork.kernel.org/project/linux-wireless/patch/20230714081619.2032-1-duminjie@vivo.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

\
 
 \ /
  Last update: 2023-07-25 16:30    [W:0.027 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site