Messages in this thread | | | Date | Tue, 25 Jul 2023 16:27:16 +0200 | Subject | Re: [PATCH v2 0/3] platform/x86: move simatic drivers into subdir | From | Hans de Goede <> |
| |
Hi,
On 7/19/23 18:06, Andy Shevchenko wrote: > On Wed, Jul 19, 2023 at 05:35:15PM +0200, Henning Schild wrote: >> change since v1: >> - switch LED/wdt Kconfig to "default y" >> - remove guard which could hide whole siemens submenu, and default m >> >> This series does two things. It builds up a Kconfig inheritance chain >> for all platform device drivers, namely Watchdog and LED. And then it >> puts all Siemens Simatic IPC drivers in the platform/x86/ directory in >> a subdirectory called "siemens". >> >> That is so that users have to flip less config switches, and to ease >> maintenance. > > All three good enough, although I prefer the ordering that 'tristate' > followed by 'default' without interleaved 'depends on'. I leave it > to Hans. Other that that, > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you.
Lee, Guenter do you want me to take the entire series on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=platform-drivers-x86-simatic-ipc (aka ib-pdx86-simatic-v6.6)
And send an updated pull-req ?
Or shall I take just 3/3 and will you take the Kconfig changes from 1/3 resp 2/3 directly ?
Regards,
Hans
| |