lkml.org 
[lkml]   [2023]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2 08/14] selftests/nolibc: string the core targets
    Date
    > On Wed, Jul 19, 2023 at 09:26:01PM +0800, Zhangjin Wu wrote:
    > > To avoid run targets one by one manually and boringly, let's string them
    > > with IMAGE and .config, the MAKE command will trigger the dependencies
    > > for us.
    > >
    > > Note, to allow do menuconfig before extconfig manually, only trigger
    > > defconfig while the .config is not there, it means only trigger
    > > defconfig for the first run or after a mrproper.
    > >
    > > Signed-off-by: Zhangjin Wu <falcon@tinylab.org>
    > > ---
    > > tools/testing/selftests/nolibc/Makefile | 18 +++++++++++++-----
    > > 1 file changed, 13 insertions(+), 5 deletions(-)
    > >
    > > diff --git a/tools/testing/selftests/nolibc/Makefile b/tools/testing/selftests/nolibc/Makefile
    > > index 83cb4b017bef..541f3565e584 100644
    > > --- a/tools/testing/selftests/nolibc/Makefile
    > > +++ b/tools/testing/selftests/nolibc/Makefile
    > (...)
    > > -extconfig:
    > > +extconfig: $(KERNEL_CONFIG)
    > > $(Q)$(srctree)/scripts/kconfig/merge_config.sh -O "$(objtree)" -m "$(KERNEL_CONFIG)" $(foreach c,$(EXTCONFIG),$(wildcard $(CURDIR)/configs/$c))
    > > $(Q)$(MAKE_KERNEL) KCONFIG_ALLCONFIG="$(KERNEL_CONFIG)" allnoconfig
    > >
    > > -kernel: initramfs
    > > +kernel: extconfig
    > > + $(Q)$(MAKE) --no-print-directory initramfs
    >
    > There seems to be something wrong here. From what I'm seeing, now if I
    > run "make kernel" it will run extconfig and possibly change the config
    > I just edited.
    >

    Yeah, extconfig will run for every 'make kernel', it is ok for us to
    let kernel depends on $(KERNEL_CONFIG), but this requires users to run
    extconfig explictly, the solution may be:

    - move extconfig operations to defconfig target and future tinyconfig target (it looks cleaner ...)

    - but it is not convenient to trigger additional changes introduced by
    extconfig, not necessary, but really helpful, something like 'menuconfig'

    - let users run extconfig manually after a defconfig or tinyconfig (it is a little complex)

    - this make users hard to learn what to do, should give up this method

    - run extconfig for every 'make kernel' as it currently do

    - this may change something after a menuconfig, but it only trigger minimal
    required options, the 'hurt' should be minimal, but of course, it may confuse sometimes ;-(

    As a summary, let's remove 'extconfig' and move its operations to the defconfig
    and the future tinyconfig targets? 'extconfig' should be a 'default' config
    action, let users apply additional ones manually from the top-level 'make
    menuconfig', what's your idea?

    > Or am I missing something ? I must confess all of this is becoming more
    > and more obscure :-(

    Yeah ... let's find a better solution ;-)

    Best regards,
    Zhangjin

    >
    > Willy

    \
     
     \ /
      Last update: 2023-07-25 16:22    [W:7.059 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site