Messages in this thread | | | Date | Tue, 25 Jul 2023 10:13:15 +0530 | Subject | Re: [PATCH v2 4/4] perf: Remove unused PERF_PMU_CAP_HETEROGENEOUS_CPUS capability | From | Anshuman Khandual <> |
| |
On 7/24/23 19:14, James Clark wrote: > Since commit bd2756811766 ("perf: Rewrite core context handling") the > relationship between perf_event_context and PMUs has changed so that > the error scenario that PERF_PMU_CAP_HETEROGENEOUS_CPUS originally > silenced no longer exists. > > Remove the capability to avoid confusion that it actually influences > any perf core behavior and shift down the following capability bits to > fill in the unused space. This change should be a no-op. > > Acked-by: Ian Rogers <irogers@google.com> > Signed-off-by: James Clark <james.clark@arm.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> --- > include/linux/perf_event.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h > index 2166a69e3bf2..c617badd1e76 100644 > --- a/include/linux/perf_event.h > +++ b/include/linux/perf_event.h > @@ -288,10 +288,9 @@ struct perf_event_pmu_context; > #define PERF_PMU_CAP_EXTENDED_REGS 0x0008 > #define PERF_PMU_CAP_EXCLUSIVE 0x0010 > #define PERF_PMU_CAP_ITRACE 0x0020 > -#define PERF_PMU_CAP_HETEROGENEOUS_CPUS 0x0040 > -#define PERF_PMU_CAP_NO_EXCLUDE 0x0080 > -#define PERF_PMU_CAP_AUX_OUTPUT 0x0100 > -#define PERF_PMU_CAP_EXTENDED_HW_TYPE 0x0200 > +#define PERF_PMU_CAP_NO_EXCLUDE 0x0040 > +#define PERF_PMU_CAP_AUX_OUTPUT 0x0080 > +#define PERF_PMU_CAP_EXTENDED_HW_TYPE 0x0100 > > struct perf_output_handle; >
| |