Messages in this thread | | | Date | Tue, 25 Jul 2023 21:00:09 -0600 | Subject | Re: [PATCH][next] accel/qaic: remove redundant assignment to pointer pexec | From | Jeffrey Hugo <> |
| |
On 7/25/2023 5:40 AM, Colin Ian King wrote: > Pointer pexec is being assigned a value however it is never read. The > assignment is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/accel/qaic/qaic_data.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c > index e9a1cb779b30..8a6cb14f490e 100644 > --- a/drivers/accel/qaic/qaic_data.c > +++ b/drivers/accel/qaic/qaic_data.c > @@ -1320,7 +1320,6 @@ static int __qaic_execute_bo_ioctl(struct drm_device *dev, void *data, struct dr > user_data = u64_to_user_ptr(args->data); > > exec = kcalloc(args->hdr.count, size, GFP_KERNEL); > - pexec = (struct qaic_partial_execute_entry *)exec; > if (!exec) > return -ENOMEM; >
It does look like pexec is not used in this function after it was refactored. Shouldn't the declaration at the beginning of the function also be removed?
| |