Messages in this thread | | | From | <> | Subject | RE: [PATCH v5 net-next] net: phy: smsc: add WoL support to LAN8740/LAN8742 PHYs | Date | Tue, 25 Jul 2023 23:51:43 +0000 |
| |
> On Thu, 20 Jul 2023 17:40:53 -0700 Tristram.Ha@microchip.com wrote: > > +#include <linux/inetdevice.h> > > +#include <net/addrconf.h> > > +#include <net/if_inet6.h> > > +#include <net/ipv6.h> > > You don't need these includes any more, right? > > > #include <linux/smscphy.h> > > > > /* Vendor-specific PHY Definitions */ > > > +static int lan874x_set_wol(struct phy_device *phydev, > > + struct ethtool_wolinfo *wol) > > +{ > > + struct net_device *ndev = phydev->attached_dev; > > + struct smsc_phy_priv *priv = phydev->priv; > > + u16 val, val_wucsr; > > + u8 data[128]; > > + u8 datalen; > > + int rc; > > + > > + if (wol->wolopts & WAKE_PHY) > > + return -EOPNOTSUPP; > > You're not advertising the support for WAKE_PHY, so you don't have to > check if it was requested. See recent commit 55b24334c0f2.
They will be removed in next update.
| |