lkml.org 
[lkml]   [2023]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 09/13] coresight-tpdm: Add nodes for dsb edge control
    Hi Tao,

    kernel test robot noticed the following build warnings:

    [auto build test WARNING on robh/for-next]
    [also build test WARNING on linus/master v6.5-rc3 next-20230725]
    [If your patch is applied to the wrong git tree, kindly drop us a note.
    And when submitting patch, we suggest to use '--base' as documented in
    https://git-scm.com/docs/git-format-patch#_base_tree_information]

    url: https://github.com/intel-lab-lkp/linux/commits/Tao-Zhang/coresight-tpdm-Remove-the-unnecessary-lock/20230725-152235
    base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
    patch link: https://lore.kernel.org/r/1690269353-10829-10-git-send-email-quic_taozha%40quicinc.com
    patch subject: [PATCH v7 09/13] coresight-tpdm: Add nodes for dsb edge control
    config: arm-randconfig-r013-20230725 (https://download.01.org/0day-ci/archive/20230726/202307260533.MTqa5ObG-lkp@intel.com/config)
    compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
    reproduce: (https://download.01.org/0day-ci/archive/20230726/202307260533.MTqa5ObG-lkp@intel.com/reproduce)

    If you fix the issue in a separate patch/commit (i.e. not just a new version of
    the same patch/commit), kindly add following tags
    | Reported-by: kernel test robot <lkp@intel.com>
    | Closes: https://lore.kernel.org/oe-kbuild-all/202307260533.MTqa5ObG-lkp@intel.com/

    All warnings (new ones prefixed by >>):

    drivers/hwtracing/coresight/coresight-tpdm.c:383:21: warning: variable 'mask' set but not used [-Wunused-but-set-variable]
    383 | unsigned long val, mask, edge_ctrl;
    | ^
    >> drivers/hwtracing/coresight/coresight-tpdm.c:451:3: warning: misleading indentation; statement is not part of the previous 'else' [-Wmisleading-indentation]
    451 | drvdata->dsb->edge_ctrl_mask[reg] = set;
    | ^
    drivers/hwtracing/coresight/coresight-tpdm.c:449:2: note: previous statement is here
    449 | else
    | ^
    2 warnings generated.


    vim +/else +451 drivers/hwtracing/coresight/coresight-tpdm.c

    426
    427 static ssize_t dsb_edge_ctrl_mask_store(struct device *dev,
    428 struct device_attribute *attr,
    429 const char *buf,
    430 size_t size)
    431 {
    432 struct tpdm_drvdata *drvdata = dev_get_drvdata(dev->parent);
    433 unsigned long val;
    434 u32 set;
    435 int reg;
    436
    437 if ((kstrtoul(buf, 0, &val)) || (val & ~1UL))
    438 return -EINVAL;
    439
    440 spin_lock(&drvdata->spinlock);
    441 /*
    442 * There is 1 bit per DSB Edge Control Mark line.
    443 * Thus we have 32 lines in a 32bit word.
    444 */
    445 reg = EDCMR_TO_WORD_IDX(drvdata->dsb->edge_ctrl_idx);
    446 set = drvdata->dsb->edge_ctrl_mask[reg];
    447 if (val)
    448 set |= BIT(EDCMR_TO_WORD_SHIFT(drvdata->dsb->edge_ctrl_idx));
    449 else
    450 set &= ~BIT(EDCMR_TO_WORD_SHIFT(drvdata->dsb->edge_ctrl_idx));
    > 451 drvdata->dsb->edge_ctrl_mask[reg] = set;
    452 spin_unlock(&drvdata->spinlock);
    453
    454 return size;
    455 }
    456 static DEVICE_ATTR_RW(dsb_edge_ctrl_mask);
    457

    --
    0-DAY CI Kernel Test Service
    https://github.com/intel/lkp-tests/wiki

    \
     
     \ /
      Last update: 2023-07-26 00:03    [W:7.639 / U:0.264 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site